Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selector stuff from VarInfo tests and link/invlink #780

Merged
merged 33 commits into from
Jan 30, 2025

Apply suggestions from code review

f99effe
Select commit
Loading
Failed to load commit list.
Merged

Remove selector stuff from VarInfo tests and link/invlink #780

Apply suggestions from code review
f99effe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 28, 2025 in 0s

85.54% (-0.62%) compared to af65bb0

View this Pull Request on Codecov

85.54% (-0.62%) compared to af65bb0

Details

Codecov Report

Attention: Patch coverage is 90.69767% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.54%. Comparing base (af65bb0) to head (f99effe).
Report is 4 commits behind head on release-0.35.

Files with missing lines Patch % Lines
src/abstract_varinfo.jl 84.90% 8 Missing ⚠️
src/threadsafe.jl 33.33% 4 Missing ⚠️
src/varinfo.jl 95.69% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-0.35     #780      +/-   ##
================================================
- Coverage         86.16%   85.54%   -0.62%     
================================================
  Files                36       36              
  Lines              4301     4380      +79     
================================================
+ Hits               3706     3747      +41     
- Misses              595      633      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.