Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ad.jl #2140

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Update ad.jl #2140

merged 1 commit into from
Dec 13, 2023

Conversation

yebai
Copy link
Member

@yebai yebai commented Dec 13, 2023

Remove the obsolete verifygrad function.

@yebai yebai requested a review from sunxd3 December 13, 2023 15:27
@sunxd3
Copy link
Member

sunxd3 commented Dec 13, 2023

@yebai I don't have permission to merge

@yebai
Copy link
Member Author

yebai commented Dec 13, 2023

@sunxd3, you should have permission now. Can you take a look at the optimisation related CI failure? I don't think it is from this PR.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6649f10) 0.00% compared to head (670f198) 0.00%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/mcmc/hmc.jl 0.00% 7 Missing ⚠️
src/essential/ad.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2140   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1421    1384   -37     
======================================
+ Misses       1421    1384   -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yebai yebai merged commit 6f13998 into master Dec 13, 2023
5 of 13 checks passed
@yebai yebai deleted the yebai-patch-1 branch December 13, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants