Optimization compat fix #2250
Closed
Optimization compat fix #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, should have seen that coming. Optimization.jl 3.21 only supports Julia 1.9 and up. |
|
See #2251 |
mhauru
force-pushed
the
mhauru/scimlbase-compat-fix
branch
from
d941581 to
ebc36af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2237 we are running into test failures on Julia 1.7 because SciMLBase 1.92 is getting installed. This causes problems when we pass ADTypes to
OptimizationFunctions, used in mode estimation, since SciMLBase 1.92.1 is the first version that made SciMLBase's AbstractADType be the same as that from ADTypes. This PR fixes our compat with Optimization.jl to be 3.21 or greater, since 3.21 is when Optimization.jl dropped support for SciMLBase 1.*.