Re-enable coverage uploads #2283
Conversation
| - uses: actions/cache@v4 | ||
| - uses: julia-actions/cache@v1 | ||
| - uses: julia-actions/julia-buildpkg@v1 | ||
| # TODO: Use julia-actions/julia-runtest when test_args are supported |
There was a problem hiding this comment.
I think it's a quite unfortunate consequence of #2237 that we have to work around the standard tooling in the Julia ecosystem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2283 +/- ##
===========================================
+ Coverage 0.00% 83.15% +83.15%
===========================================
Files 22 24 +2
Lines 1528 1591 +63
===========================================
+ Hits 0 1323 +1323
+ Misses 1528 268 -1260 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I didn't know of the coveralls parallel option, that's really neat and makes this much easier than I thought it would be. Thanks @devmotion!
I had one tiny style point to made, but I'll approve already since it's fine to merge as-is.
.github/workflows/Tests.yml
Outdated
| env: | ||
| cache-name: cache-artifacts | ||
| COVERAGE: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' && matrix.num_threads == 2 }} |
There was a problem hiding this comment.
I tiny detail, but ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' && matrix.num_threads == 2 }} could be stored in a variable and thus defined once, making sure the different if-clauses always use the same condition.
Fixes #2282.