Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Merge #2317

Closed
wants to merge 3 commits into from
Closed

Do Not Merge #2317

wants to merge 3 commits into from

Conversation

willtebbutt
Copy link
Member

I'm initially going to try and confirm that CI does indeed run correctly on the previous patch version of Tapir.jl. If so, I'll be able to dig into exactly what is going on, and try to fix that.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (78d110a) to head (91a125f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
- Coverage   86.80%   86.67%   -0.13%     
==========================================
  Files          24       24              
  Lines        1599     1599              
==========================================
- Hits         1388     1386       -2     
- Misses        211      213       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10828546658

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 644 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-41.4%) to 45.623%

Files with Coverage Reduction New Missed Lines %
src/essential/container.jl 1 87.1%
src/variational/VariationalInference.jl 4 14.29%
src/mcmc/gibbs_conditional.jl 12 0.0%
src/mcmc/gibbs.jl 13 83.33%
src/mcmc/is.jl 16 0.0%
src/mcmc/hmc.jl 19 79.56%
src/stdlib/RandomMeasures.jl 22 0.0%
ext/TuringDynamicHMCExt.jl 29 0.0%
src/mcmc/mh.jl 32 57.43%
src/mcmc/emcee.jl 47 0.0%
Totals Coverage Status
Change from base Build 10703372980: -41.4%
Covered Lines: 714
Relevant Lines: 1565

💛 - Coveralls

@willtebbutt willtebbutt reopened this Sep 12, 2024
@willtebbutt
Copy link
Member Author

I'm closing this as the problem seems to have been fixed. I've restarted a CI run on main -- I'm expecting that to work correctly.

@yebai yebai deleted the wct/debug-tapir-slowdown branch September 12, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants