Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for x86 #2478

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix CI for x86 #2478

wants to merge 4 commits into from

Conversation

penelopeysm
Copy link
Member

This PR bumps the AdvancedPS test requirement to 0.6.1. This essentially reverts the changes in #2449, since they are no longer needed.

This is still WIP because I would like to try to get rid of the segfaults as well (by skipping the offending tests).

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (8bf98e1) to head (152a68a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2478   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          21       21           
  Lines        1570     1570           
=======================================
  Hits         1326     1326           
  Misses        244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12931388553

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.831%

Totals Coverage Status
Change from base Build 12928004698: 0.0%
Covered Lines: 1186
Relevant Lines: 1564

💛 - Coveralls

@penelopeysm
Copy link
Member Author

penelopeysm commented Jan 23, 2025

Argh, now lots of tolerances need to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants