fix mistake in prismatic joint calculation #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mistake in the parallel Jacobian calculation for prismatic joints.
(Was mentioned in #3 but not fixed)
In
jacobian.py
,f.joint.axis.repeat(N, 1)
result in shape(N,3)
and cannot multiply with the(N,3,3)
rotation matrix. Instead it shouldrepeat(N,1,1)
to get shape(N,1,3)
to multiply with(N,3,3)
.In
frame.py
, the expressiontheta * self.joint.axis
is not permitted since the tensors have shapes(N,)
and(3,)
.unsqueeze
on theta solves it.