Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow safe json upload into osnap tx builder #140

Closed
wants to merge 8 commits into from
Closed

feat: allow safe json upload into osnap tx builder #140

wants to merge 8 commits into from

Conversation

daywiss
Copy link

@daywiss daywiss commented Mar 11, 2024 •
edited by gsteenkamp89
Loading

No description provided.

@linear Linear
Copy link

linear bot commented Mar 11, 2024

UMA-2441 add new transaction type to import from safe

@vercel Vercel
Copy link

vercel bot commented Mar 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 0:12am
snapshot-goerli ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 0:12am

@daywiss daywiss marked this pull request as draft March 11, 2024 17:34
@gsteenkamp89
Copy link

gsteenkamp89 commented Mar 20, 2024 •
edited
Loading

Fixes #UMA-2431

Can drag n drop or click and choose a file.
All transactions are either

  • Native transfer, or
  • Contract interaction

screenshots:

idle state
Screenshot 2024-03-20 at 13 43 15
add file, choose transaction
Screenshot 2024-03-20 at 13 43 31
Native transfer
Screenshot 2024-03-20 at 13 43 58
Contract Interaction (includes erc20 transfers)
Screenshot 2024-03-20 at 13 43 51
If you drag n drop a non-json file
Screenshot 2024-03-20 at 14 12 25
If there is an error while attempting to parse the file. can be syntax errors in the file or the schema does not match what we expect.
Screenshot 2024-03-20 at 14 13 19

@gsteenkamp89 gsteenkamp89 marked this pull request as ready for review March 20, 2024 12:20
@gsteenkamp89 gsteenkamp89 reopened this Mar 20, 2024
@gsteenkamp89 gsteenkamp89 self-assigned this Mar 20, 2024
@daywiss
Copy link
Author

daywiss commented Mar 25, 2024

closing this in favor of #147

@daywiss daywiss closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gsteenkamp89 gsteenkamp89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daywiss @gsteenkamp89