[1주차] 제이콥/임익주 #10
Merged
[1주차] 제이콥/임익주 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongh06
reviewed
Oct 11, 2024
| <TextView | ||
| android:id="@+id/textView7" | ||
| android:layout_width="94dp" | ||
| android:layout_height="17dp" |
There was a problem hiding this comment.
text는 width랑 height를 wrap으로 통일하는것이 좋습니다
| android:text="더없이 행복한 하루였어요" | ||
| android:textAlignment="center" | ||
| android:textSize="12sp" | ||
| android:textStyle="bold" |
There was a problem hiding this comment.
textSize와 textStyle, font가 동일한 경우 style로 저장해서 쓰는것이 효율적인데 이 부분은 나중에 스터디때 알려드리겠습니다.
| app:layout_constraintTop_toTopOf="parent"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/textView2" |
There was a problem hiding this comment.
id 이름을 전체적으로 규칙을 지켜서 정하면 다른 개발자가 코드 읽기 수월합니다.
| android:layout_height="51dp" | ||
| android:layout_marginTop="25dp" | ||
| android:textAlignment="center" | ||
| app:layout_constraintEnd_toEndOf="@+id/textView4" |
There was a problem hiding this comment.
@+id는 id 이름을 지정할때 주로 쓰고
toptotop처럼 위치를 지정할 때는 @id를 주로 사용합니다.
| app:layout_constraintEnd_toEndOf="@+id/textView5" | ||
| app:layout_constraintStart_toStartOf="@+id/textView5" | ||
| app:layout_constraintTop_toBottomOf="@+id/textView5" | ||
| app:srcCompat="@drawable/group_462_2" /> |
There was a problem hiding this comment.
srcCompat의 경우 jpg파일을 사용할 수 없기때문에 src를 대부분 사용합니다.
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="5dp" | ||
| android:text="감정우표를 선택해주세요" | ||
| android:textAlignment="center" |
There was a problem hiding this comment.
wrap으로 width와 height을 지정하고 start와 end를 설정했다면 textAlignment는 불필요한 코드입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9