Review fix

[triphook]

Fixed all bugs related to downloads. Added new button for downloading final (with flagged records removed) vs intermediate (flagged rows retained) datasets.

[cristinamullin]

@triphook This is not related to your edits (was already there), but do you know if the renv folder at the top level of the repo is needed?

I also noticed a lot of notes printed when I queried the WQP on the import tab. Can you take a look to check these are correct? Thanks!

[1] "tadat$raw has been changed (i think?)"
NULL
NULL
[1] "Updating result count"
NULL
[1] "Load tab selected"
[1] "Downloading WQP query results. This may take some time depending upon the query size."
[1] "Data successfully downloaded. Running TADA_AutoClean function."
[1] "TADA_Autoclean: creating TADA-specific columns."
[1] "TADA_Autoclean: checking for special characters."
[1] "Quality control samples have been removed or were not present in the input dataframe. Returning dataframe with TADA.ActivityType.Flag column for tracking."
[1] "TADA_Autoclean: updating deprecated (i.e. retired) characteristic names."
[1] "No deprecated characteristic names found in dataset."
[1] "TADA_Autoclean: harmonizing result and depth units."
[1] "NOTE: This version of the TADA package is designed to work with quantitative (numeric) data with media name: 'WATER'. TADA_AutoClean does not currently remove (filter) data with non-water media types. If desired, the user must make this specification on their own outside of package functions. Example: dplyr::filter(.data, TADA.ActivityMediaName == 'WATER')"
[1] 6789
NULL
[1] 482
[1] "tadat$raw has been changed (i think?)"
[1] 482
[1] 482
[1] "Updating result count"
[1] 482
[1] "Removals changed"
[1] 482 0
[1] 0
[1] 0
[1] "tadat$raw has been changed (i think?)"
[1] 482
[1] 482
[1] "Updating result count"
[1] 482
[1] "tadat$raw has been changed (i think?)"
[1] 482
[1] 482
[1] "Updating result count"
[1] 482
[1] "Overview tab selected"

[hillarymarler]

In the filtering page, MeasureQualifierCode is the filter option - should the TADA.MeasureQualifierCode.Def option be visible in this update?

Downloading both test datasets and WQP queried data sets as zip files is working throughout the app.

[cristinamullin]

In the filtering page, MeasureQualifierCode is the filter option - should the TADA.MeasureQualifierCode.Def option be visible in this update?

Downloading both test datasets and WQP queried data sets as zip files is working throughout the app.

This should have happened automatically when we added this to the key fields in TADA_FieldCounts in the package, which is leveraged in mod_filtering.R. We'll have to look into why it is still not working