-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid.from_points()
with Spherical Delaunay & Voronoi
#1023
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Grid.from_points()
, Spherical Voronoi Grid.from_points()
, Global Spherical Voronoi
Grid.from_points()
, Global Spherical VoronoiGrid.from_points()
, Global Spherical Voronoi & Spherical Delaunay Triangulation
What needs to be done here in order to get it ready for review? |
I am wrapping up the implementation and documentation today. Will be requesting reviews after. We should start looking at regional triangulation using projections, like what you were doing in #442 I'll be populating the sub-issues n #349 today as well. Will assign and update you accordingly. |
Awesome! It looks good to me so far. What do you mean by regional triangulation? |
Spherical triangulation works great for data that is distributed across the sphere. If we have regional patches of data (think a subset over some arbitrary region), performing a spherical triangulation will produce extremely large triangles along the border of the region. In this case, we'd want to investigate using a planar triangulation on a projection (i.e. sterographic) like you were doing in #442 |
Gotcha that makes sense, thanks for explaining! |
Grid.from_points()
, Global Spherical Voronoi & Spherical Delaunay Triangulation Grid.from_points()
with Spherical Delaunay & Voronoi
Grid.from_points()
with Spherical Delaunay & Voronoi Grid.from_points()
with Spherical Delaunay & Voronoi
Is this ready for review now? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good foundational work, we can specify laplacian smoothing etc. as a follow up PR.
Did some more digging - |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I will finish the regional delaunay part hopefully next week and get that added in as well. Just fix the merge conflicts and it's good to go!
Overview
Grid.from_points()
class method which is used to construct grid connectivity from unstructured grid pointsGrid.triangular
Grid.partial_sphere_coverage
Grid.global_sphere_coverage
Grid.boundary_node_indices
Grid.boundary_face_indices
Grid.plot.face_area_distrubtion()
Grid.plot.face_degree_distribution()
User Guide
User guide notebook showcasing how to construct a grid from points consider the various types of distributions that are possible (global, global with holes, regional, and regional with holes)