Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE_TEMPLATE, PULL_REQUEST_TEMPLATE guidelines updated. #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ISSUE_TEMPLATE, PULL_REQUEST_TEMPLATE guidelines updated. #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76dde67
refactored .github guidelines
optimistanoop Apr 19, 2018
d79bf3e
review changes for pull_request template
optimistanoop May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ a proposal for your work first, to be sure that we can use it.
Before you submit an issue, please search the issue tracker, maybe an issue for your identified problem already exists and you can join the discussion there only.
For bugs, please try to provide as much information possible to reproduce it as possible, that will really help us a lot!

**Great Bug Reports** tend to have:

- A quick summary and/or background
- Steps to reproduce
- Be specific!
- Give sample code if you can.
- What you expected would happen
- What actually happens
- Notes (possibly including why you think this might be happening, or stuff you tried that didn't work)

### <a name="submit-pr"></a> Submitting a Pull Request (PR)
1. Make sure there is an issue open for the PR and it is assigned to you before starting any work. That way it'll be helpful to eliminate duplicate efforts.
2. Fork the repo. If already have one, checkout the latest master from upstream.
Expand Down
20 changes: 16 additions & 4 deletions .github/ISSUE_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,23 @@
**I'm submitting a ...**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the earlier text was better.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palnabarun @ritikrishu @ParthS007 I feel a lot of friction in the process of review/ approval.
I think you all moderators should agree to a same point. Its impossible implement multiple thoughts on the same change.

Secondly, In this PR, I have made changes more than 3-4 times based on all reviews given by all moderators. So for the sake of simplicity and fast review/approval system, please suggest a final change and lets close this PR.

- [ ] bug report
- [ ] feature request
# Template to submit an issue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@optimistanoop Only add


- [ ] I have read the [contribution guidelines](https://github.com/UdacityMobileWebScholarship/showcase-app/blob/master/.github/CONTRIBUTING.md)

-**I'm submitting a ...**
<!-- Delete the reasons that don't apply. -->

- [ ] bug report
- [ ] feature request

**Current behavior:**
<!-- How the bug manifests. -->
<!-- How the bug manifests.
- [ ] `node -v` prints:
- [ ] Windows, OS X/macOS, or Linux?: -->

**Expected behavior:**
<!-- Behavior would be without the bug. -->

**Steps to reproduce:**
<!-- Give a complete description of how to reproduce the problem. -->



17 changes: 14 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
<!-- Add the issue number that is fixed by this PR (In the form Fixes #123) -->
<!--
Thanks for contributing to the project. Please follow the guidelines
below:
Please provide reference to active issue here.
Add the issue number that is fixed by this PR (In the form Fixes #123)

Attention !!

An active issue is required for a PR to be reviewed.
If you do not provide one, you pull request might be closed by collaborators.-->
Fixes #

#### Checklist
Expand All @@ -9,5 +18,7 @@ Fixes #

#### Changes proposed in this pull request:

-
-
<!-- Describe how this PR will make our project even more awesome. -->