Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added mobile designs, fixed formatting #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blenderskool
Copy link
Contributor

@blenderskool blenderskool commented Apr 30, 2018

Improved #31
Reference #39

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added/updated necessary tests/documentation (if applicable)

Changes in this pull request:

  • Added Mobile designs
  • Improved formatting

@divyamrastogi
Copy link
Collaborator

@blenderskool : This looks really good.
Just one last thing, can you upload all the Mobile and Desktop Designs .gvdesign files on to our project design page like before?

@realslimshanky
Copy link
Collaborator

I can see a minor color difference between Mobile and Desktop view. Please fix that. The color palette on Mobile view looks great.

  • Mobile
    image

  • Desktop
    image

@blenderskool
Copy link
Contributor Author

@realslimshanky Yes, there has been some confusion with that. I and @anurag-majumdar have decided a single style guide for the app. We will use all the colors and fonts mentioned in this style guide in place of the other ones 🙂

@blenderskool
Copy link
Contributor Author

@divyamrastogi Since the designs are hosted on Google Photos, I cannot upload the design files there, hence I will try to upload it somewhere else and update the Design Guidelines with the links to those files

@realslimshanky
Copy link
Collaborator

@blenderskool make sure you make changes to this album only
https://photos.app.goo.gl/5nm1W01LSmGwOfGh2
later we can add images directly to the README.md and other docs which will eliminate the use of a third party service as design guideline host. It's good to have all the major parts at the same place.

@blenderskool
Copy link
Contributor Author

@realslimshanky Yes, all design changes and additions later will be added there itself 🙂

@anurag-majumdar
Copy link
Contributor

Sure @realslimshanky. We will be using the colours from @blenderskool designs but the desktop layouts (wireframe) will remain.

@realslimshanky realslimshanky changed the title Added mobile designs, fixed formatting [WIP] Added mobile designs, fixed formatting May 10, 2018
@realslimshanky
Copy link
Collaborator

@blenderskool @anurag-majumdar I've added [WIP] to the title. Please rename the title when you guys are done with the updates.

@blenderskool
Copy link
Contributor Author

@realslimshanky I think all designs are ready. We can merge this so that other developers can refer to the guidelines as soon as possible 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants