Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the logo files #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blenderskool
Copy link
Contributor

Fixes #35

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added/updated necessary tests/documentation (if applicable)

Changes proposed in this pull request:

  • Added the required logo files in standard formats (.png and .svg)
  • App icons include Circular & Square type - This can be finalized and additional image sizes for PWA support can be added later
  • Also added favicons(.ico) in two sizes - They can be resized based on the requirements

@realslimshanky
Copy link
Collaborator

I have following concerns

  • Please don't give space between files of folder names.
  • Could you also create 2 separate folders inside src/assets/Logo/AppIcon/, one for Light and one for Dark. So that we can have similar icons in all the format in both the folder.

@blenderskool
Copy link
Contributor Author

@realslimshanky Ok, I will make the necessary changes.

@blenderskool
Copy link
Contributor Author

@realslimshanky I have made the changes

@realslimshanky
Copy link
Collaborator

Does the Circular and Round to the Light category? If that's the case please move them to respective directory and also add two new logos similar to them for Dark.

@blenderskool
Copy link
Contributor Author

@realslimshanky Those icons are the independent of the theme. I think app icons look good only in light version hence just created them

@realslimshanky
Copy link
Collaborator

realslimshanky commented May 8, 2018

@blenderskool okay, got it.

Copy link
Collaborator

@realslimshanky realslimshanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blenderskool
Copy link
Contributor Author

A gentle reminder, please review the files and let me know if any changes are required 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Logo
3 participants