Fixed memory leak when using live progress #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ohhh nice catch! This fixes #117 I'm pretty sure :) |
Ullaakut
approved these changes
Sep 4, 2024
|
There seems to be a problem with the tests right? |
|
Would it be possible to create a new tag for the new changes, so they can be imported as a library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the live progress with big subnets, at some point the memory will rise very high.
Sometimes up to Gigabytes.
By moving the declaration of the progress variable into the loop this is fixed and the memory will stay in the low Megabytes.