CURA-11978 Retract and unretract in a travel #2204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-11978 Unretraction during travel computed but not applied yet
…-in-a-travel' into CURA-11978_retract-and-unretract-in-a-travel
…d-unretract-in-a-travel
…-in-a-travel' into CURA-11978_retract-and-unretract-in-a-travel
jellespijker
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Overal it looks good and well thought out, a couple of minor remarks and suggestions. But I do suggest adding some UT
given the complexity of splitting travel moves into multiple phases, maybe add unit and integration tests that cover:
- A travel move with enough duration for all retraction/priming to happen during travel.
- A travel move where extra stationary time is required.
- Edge cases with only one travel segment.
- Both “forward” (retraction) and “reversed” (priming) computations.
…-in-a-travel' into CURA-11978_retract-and-unretract-in-a-travel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies retraction and priming during travel move, partially or completely according to the given settings.
Most calculations are done according to durations, because we want to respect both the travel speed and the retraction/prime speed. If we don't have enough time to process the retraction/prime during travel, we will make a stationary retraction/prime irregardless of the setting, because there is no other way to respect the speeds.
Requires Ultimaker/Cura#20240
CURA-11978