Skip to content

Commit

Permalink
Merge pull request #1242 from UniStuttgart-VISUS/glslang
Browse files Browse the repository at this point in the history
Fix glslang binary name deprecation
  • Loading branch information
moritz-h authored Jan 11, 2024
2 parents 754d62d + 2939514 commit fe3c0b0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .ci/check_shaders.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ for sdir in "${SHADER_DIRS[@]}"; do
LOCAL_INCLUDE_PATHS=("-I$(pwd)/$(dirname "$sfile")")

glslang_exit_code=0
output="$(glslangValidator -l "${INCLUDE_PATHS[@]}" --p "#extension GL_GOOGLE_include_directive : require" "${LOCAL_INCLUDE_PATHS[@]}" $sfile)" || glslang_exit_code=$?
output="$(glslang -l "${INCLUDE_PATHS[@]}" --p "#extension GL_GOOGLE_include_directive : require" "${LOCAL_INCLUDE_PATHS[@]}" $sfile)" || glslang_exit_code=$?
if [[ $glslang_exit_code -ne 0 ]]; then
echo ""
echo "::error::########## glslangValidator found issues in $sfile ##########"
echo "::error::########## glslang found issues in $sfile ##########"
echo "$output"
EXIT_CODE=1
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/shader_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
run: |
mkdir bin
wget "https://github.com/KhronosGroup/glslang/releases/download/main-tot/glslang-main-linux-Release.zip"
unzip -j "glslang-main-linux-Release.zip" "bin/glslangValidator" -d ./bin
unzip -j "glslang-main-linux-Release.zip" "bin/glslang" -d ./bin
rm "glslang-main-linux-Release.zip"
echo "./bin" >> $GITHUB_PATH
- name: Run shader check
Expand Down

0 comments on commit fe3c0b0

Please sign in to comment.