Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload-artifact/download-artifact for github actions #3065

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Update upload-artifact/download-artifact for github actions #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a23468
Update upload artifact action in support of https://github.com/Unidat…
WardF Dec 16, 2024
428db8d
Merging in main branch.
WardF Dec 20, 2024
b57c933
Add job name to avoid namespace collision
WardF Dec 20, 2024
fbf6d80
Correct logic to avoid a namespace conflict.
WardF Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions .github/workflows/run_tests_ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ jobs:

build-deps-serial:

runs-on: ubuntu-22.04

strategy:
matrix:
hdf5: [ 1.10.8, 1.12.2, 1.14.3 ]
runs-on: [ ubuntu-22.04 ]

runs-on: ${{ matrix.runs-on }}

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -146,11 +147,13 @@ jobs:
nc-ac-tests-oneoff-serial-shared:

needs: build-deps-serial
runs-on: ubuntu-22.04

strategy:
matrix:
hdf5: [ 1.14.3 ]
runs-on: [ ubuntu-22.04 ]

runs-on: ${{ matrix.runs-on }}
steps:

- uses: actions/checkout@v4
Expand Down Expand Up @@ -227,9 +230,9 @@ jobs:
if: ${{ success() }}
run: make dist -j

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: netcdf-c-autotools-source-distribution
name: netcdf-c-autotools-source-distribution-${{ matrix.runs-on }}
path: |
*.tar*
*.zip
Expand All @@ -241,11 +244,13 @@ jobs:
nc-ac-tests-oneoff-serial-static:

needs: build-deps-serial
runs-on: ubuntu-22.04

strategy:
matrix:
hdf5: [ 1.14.3 ]
runs-on: [ ubuntu-22.04 ]

runs-on: ${{ matrix.runs-on }}
steps:

- uses: actions/checkout@v4
Expand Down Expand Up @@ -322,15 +327,6 @@ jobs:
if: ${{ success() }}
run: make dist -j

- uses: actions/upload-artifact@v3
with:
name: netcdf-c-autotools-source-distribution
path: |
*.tar*
*.zip
*.tgz


##
# Parallel
##
Expand Down Expand Up @@ -656,19 +652,22 @@ jobs:
nc-autotools:

needs: [ nc-cmake-tests-oneoff-serial-shared, nc-cmake-tests-oneoff-serial-static, nc-ac-tests-oneoff-serial-shared, nc-ac-tests-oneoff-serial-static, nc-cmake-tests-oneoff-parallel, nc-ac-tests-oneoff-parallel ]
runs-on: ubuntu-22.04


strategy:
matrix:
hdf5: [1.10.8, 1.12.2, 1.14.3 ]
use_nc4: [ nc3, nc4 ]
use_dap: [ dap_off, dap_on ]
use_nczarr: [ nczarr_off, nczarr_on ]
runs-on: [ ubuntu-22.04 ]

runs-on: ${{ matrix.runs-on }}
steps:

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: netcdf-c-autotools-source-distribution
name: netcdf-c-autotools-source-distribution-${{ matrix.runs-on }}

- name: Unpack source distribution
shell: bash -l {0}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run_tests_win_mingw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ jobs:

- name: Upload test failures
if: ${{ failure() && steps.tests.conclusion == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: mingw-autotools-test-logs
name: mingw-autotools-test-logs-${{ matrix.msystem }}
path: |
*/*.log
*/*.trs
Expand Down
Loading