-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix scale offset applied twice #1247
fix scale offset applied twice #1247
Conversation
a93bf2b
to
4452bdf
Compare
fix scale offset applied twice remove extra calls to convert
659c175
to
573adf4
Compare
573adf4
to
9a57f50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job getting this done! 🎉 Do you think it's easy to add a test for the scale/offset applied twice to time axes bug? Some of this code may be hard to unit test but we could always add one to the TDS/ NCSS if that's easier.
The scale/offset applied twice by nccs and the TDS bug is being tested already by all the tests that check that the scale and offset properties are removed, but I was also planning on putting a test in the TDS. The thing with the time axes calling |
fix scale offset applied twice
remove extra calls to convert for performance