Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scale offset applied twice #1247

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

haileyajohnson
Copy link
Contributor

fix scale offset applied twice

remove extra calls to convert for performance

@haileyajohnson haileyajohnson force-pushed the scale-offset branch 2 times, most recently from 659c175 to 573adf4 Compare November 28, 2023 00:08
@haileyajohnson haileyajohnson marked this pull request as ready for review November 28, 2023 20:05
Copy link
Contributor

@tdrwenski tdrwenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job getting this done! 🎉 Do you think it's easy to add a test for the scale/offset applied twice to time axes bug? Some of this code may be hard to unit test but we could always add one to the TDS/ NCSS if that's easier.

@haileyajohnson
Copy link
Contributor Author

The scale/offset applied twice by nccs and the TDS bug is being tested already by all the tests that check that the scale and offset properties are removed, but I was also planning on putting a test in the TDS. The thing with the time axes calling read and convert over and over is kinda hard to test because it doesn't actually change any results, so for me to test it I had to manually count how many times that code was hit...

@haileyajohnson haileyajohnson merged commit 4ba9bb9 into Unidata:maint-5.x Nov 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants