Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zarr last modified #1285

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix Zarr last modified #1285

merged 3 commits into from
Jan 17, 2024

Conversation

tdrwenski
Copy link
Contributor

Description of Changes

Changes needed for Unidata/tds#444:

  • add getLastModified override to ZarrIosp which uses the raf's last modified. This is instead of using the default one which creates an MFile based on the path, which doesn't work correctly for local zips and S3 zarr "directories".
  • Fix issue in the ZarrHeader that the raf belonging to the item is closed while item is still in use.
  • Add test

@tdrwenski tdrwenski mentioned this pull request Jan 16, 2024
Merged
@tdrwenski tdrwenski marked this pull request as ready for review January 16, 2024 18:35
@tdrwenski tdrwenski merged commit bb69bbd into Unidata:maint-5.x Jan 17, 2024
10 checks passed
@tdrwenski tdrwenski deleted the zarr-last-modified branch January 17, 2024 15:56
@tdrwenski tdrwenski mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdrwenski @haileyajohnson