Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for BUFR delayed replication descriptor #1291

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix for BUFR delayed replication descriptor #1291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
289485e
Fix for BUFR delayed replication descriptor
michaeldiener Jan 19, 2024
7e010d5
Merge branch 'maint-5.x' into maint-5.x_bufr
Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bufr/src/main/java/ucar/nc2/iosp/bufr/DataDescriptorTreeConstructor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ private List<DataDescriptor> replicate(List<DataDescriptor> keys) {

// the next one is the replication count size : does not count in field count (x)
DataDescriptor replication = dkIter.next();
if (replication.y == 0)

// see https://github.com/Unidata/netcdf-java/issues/1282
if (replication.x == 31)
dk.replicationCountSize = replication.bitWidth;
// Not sure about the following hard codes values and if the previous condition (replication.x == 31) already
// captures those cases automatically. Ideally need an expert for BUFR to look over these.
else if (replication.y == 0)
dk.replicationCountSize = 1; // ??
else if (replication.y == 1)
dk.replicationCountSize = 8;
Expand Down
Loading