Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github actions #1398

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Upgrade github actions #1398

merged 3 commits into from
Dec 11, 2024

Conversation

lesserwhirls
Copy link
Collaborator

@lesserwhirls lesserwhirls commented Dec 11, 2024

Description of Changes

GitHub is closing down actions/cache v1 and v2, and this PR bumps us to the latest (v4). This also bumps actions/setup-java to the latest version (v4).

Also, disable the dap2 test that hits iridl.ldeo.columbia.edu (see #1396 (comment)) when testing PRs, and update the CODEOWNERS file.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@lesserwhirls lesserwhirls added the build: github Issue or pull request related to the GitHub build infrastructure. label Dec 11, 2024
@lesserwhirls lesserwhirls marked this pull request as ready for review December 11, 2024 17:09
GitHub appears to have intermittent access issues when running a dap2 test against iridl.ldeo.columbia.edu (see Unidata#1396 (comment)). Disable this specific test for pull requests, but still run locally and on jenkins. Also, they have upgraded their server to support https, so we will use that in the test.
@lesserwhirls
Copy link
Collaborator Author

@DennisHeimbigner - would you like to remain in the CODEOWNERS file? It's currently setup to automatically tag you as a reviewer for changes made to anything living under httpservices/**,netcdf4/**, **/opendap/**, and **/dap4/**.

@DennisHeimbigner
Copy link
Collaborator

If I am useful in that role, then yes. But I will defer to Ward about this.

@DennisHeimbigner
Copy link
Collaborator

And of course defer to you about the Java repositories. I am ok either way.

@lesserwhirls
Copy link
Collaborator Author

Thank you Dennis! I'd love to keep you in the loop on the dap2/dap4/netcdf4/httpservices netCDF-Java modules as long as you are willing (and if at any point the notifications become too much, just let me know!) The only dap2 related change is this PR is to disable a test that hits iridl.ldeo.columbia.edu, as I have noticed over the years that github periodically has trouble reaching the site (the test will still be run as part of other testing workflows, just not GitHub pull requests).

@DennisHeimbigner
Copy link
Collaborator

If memory serves, may years ago, Columbia was running a fork of the OPeNDAP Hyrax DAP2 server.
At the time, we decided to support the Columbia server. It is possible that they no longer
run a modified server. If they use standard Hyrax, then there is no particular point
in having a special test. We could also remove whatever quirky change they implemented from
our code.

@lesserwhirls
Copy link
Collaborator Author

It looks like that is still the case (InGrid Docs).

@DennisHeimbigner
Copy link
Collaborator

Sigh! Oh well.

@lesserwhirls lesserwhirls merged commit 012786e into Unidata:maint-5.x Dec 11, 2024
8 checks passed
@lesserwhirls lesserwhirls deleted the actions branch December 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build: github Issue or pull request related to the GitHub build infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants