Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_tocdl to pass on Windows. #1395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ELundby45
Copy link

Fixes test_tocdl on Windows.

The expected output is:

netcdf ubyte {
dimensions:
        d = 2 ;
variables:
        byte ub(d) ;
                ub:_Unsigned = "true" ;
        byte sb(d) ;
        byte sb2(d) ;
                sb2:_Unsigned = "false" ;

// global attributes:
                :_Format = "classic" ;
}

But when the full path is provided, the output is something like:

netcdf C\:\\Users\\dev-admin\\Desktop\\netcdf\\netcdf4_1737132718267\\test_tmp\\test\\ubyte {
dimensions:
        d = 2 ;
variables:
        byte ub(d) ;
                ub:_Unsigned = "true" ;
        byte sb(d) ;
        byte sb2(d) ;
                sb2:_Unsigned = "false" ;

// global attributes:
                :_Format = "classic" ;
}

Using the basename fixes this.

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

@ELundby45
Copy link
Author

Looks like this issue might be isolated to my environment. Feel free to close this if it's not helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants