Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish: Remove mentions of Slack #141

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Sep 22, 2020

Closes #140.

@hmpf hmpf added the polish Nice to have label Sep 22, 2020
@hmpf hmpf added this to the Version 1 milestone Sep 23, 2020
@hmpf hmpf force-pushed the polish-remove-slack-mentions branch from 32cc176 to 50dd9c3 Compare September 23, 2020 09:47
Copy link
Contributor

@jorgenbele jorgenbele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires that the MediaAlternative type is changed as well:

export type MediaAlternative = "EM" | "SM" | "SL";
. Remove "SL" from here.

@hmpf
Copy link
Contributor Author

hmpf commented Sep 25, 2020

I'm so making an endpoint in the API for this. Media need to be configurable at least from the admin. hmpf

@hmpf hmpf requested a review from jorgenbele September 25, 2020 12:52
@jorgenbele jorgenbele merged commit 18387a7 into Uninett:master Sep 27, 2020
@hmpf hmpf deleted the polish-remove-slack-mentions branch August 5, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish: Remove any mention of slack
2 participants