-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media refactor: prep for sending SMSes in addition to email #105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 70.12% 69.45% -0.67%
==========================================
Files 34 36 +2
Lines 1339 1349 +10
==========================================
- Hits 939 937 -2
- Misses 400 412 +12
Continue to review full report at Codecov.
|
I realized while writing the documentation that more refactoring is needed. Currently it is not the notification-medium that selects which email-address or phone number to use, that happens before we hit the class. I'm thinking that logic should be in the class. Not in the |
I've recorded some refactoring ideas in #121. I'm merging the current state in, so that there is a notification system. |
Depends on #102 as well as #104.