Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media refactor: prep for sending SMSes in addition to email #105

Merged
merged 5 commits into from
Aug 12, 2020

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Aug 7, 2020

Depends on #102 as well as #104.

@hmpf hmpf requested a review from ddabble August 7, 2020 09:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #105 into master will decrease coverage by 0.66%.
The diff coverage is 43.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   70.12%   69.45%   -0.67%     
==========================================
  Files          34       36       +2     
  Lines        1339     1349      +10     
==========================================
- Hits          939      937       -2     
- Misses        400      412      +12     
Impacted Files Coverage Δ
src/argus/notificationprofile/media/email.py 33.33% <33.33%> (ø)
src/argus/notificationprofile/media/__init__.py 41.17% <41.17%> (ø)
src/argus/notificationprofile/media/base.py 88.88% <88.88%> (ø)
src/argus/incident/views.py 70.75% <100.00%> (-0.28%) ⬇️
src/argus/site/utils.py 70.37% <0.00%> (-2.05%) ⬇️
src/argus/auth/views.py 81.25% <0.00%> (-1.11%) ⬇️
src/argus/incident/models.py 77.30% <0.00%> (-0.93%) ⬇️
src/argus/notificationprofile/views.py 70.96% <0.00%> (-0.91%) ⬇️
src/argus/incident/fields.py 89.18% <0.00%> (-0.29%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a4f2f...0c97659. Read the comment docs.

@hmpf hmpf mentioned this pull request Aug 7, 2020
@hmpf hmpf requested a review from jorgenbele August 7, 2020 12:47
@hmpf
Copy link
Contributor Author

hmpf commented Aug 10, 2020

I realized while writing the documentation that more refactoring is needed. Currently it is not the notification-medium that selects which email-address or phone number to use, that happens before we hit the class. I'm thinking that logic should be in the class. Not in the send()-method, but a new method that needs a notification profile. I'll push that documentation change anyway since it does describe the situation resulting from this and the previous PRs in this series.

@hmpf hmpf marked this pull request as draft August 10, 2020 12:31
@hmpf hmpf mentioned this pull request Aug 12, 2020
21 tasks
@hmpf
Copy link
Contributor Author

hmpf commented Aug 12, 2020

I've recorded some refactoring ideas in #121. I'm merging the current state in, so that there is a notification system.

@hmpf hmpf marked this pull request as ready for review August 12, 2020 12:54
@hmpf hmpf merged commit 9a4bbff into Uninett:master Aug 12, 2020
@hmpf hmpf deleted the media-refactor branch August 13, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants