Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise error msg on destination delete #1148

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

podliashanyk
Copy link
Contributor

Closes #1147

@podliashanyk podliashanyk added the bug Something is not working as expected label Jan 22, 2025
@podliashanyk podliashanyk requested a review from a team January 22, 2025 12:53
@podliashanyk podliashanyk self-assigned this Jan 22, 2025
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nitpick about the news fragment

changelog.d/1147.fixed.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 22, 2025

Test results

   10 files  1 060 suites   38m 5s ⏱️
  536 tests   535 ✅  1 💤 0 ❌
5 360 runs  5 350 ✅ 10 💤 0 ❌

Results for commit d28be46.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (605b38e) to head (d28be46).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/htmx/destination/views.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files         141      141           
  Lines        5442     5442           
=======================================
  Hits         4271     4271           
  Misses       1171     1171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stveit stveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but agree with johanna on rewording the changelog fragment

Co-authored-by: Johanna England <[email protected]>
@podliashanyk podliashanyk merged commit 7564dae into master Jan 24, 2025
17 checks passed
@podliashanyk podliashanyk deleted the more-precise-error-msg-on-destination-delete branch January 24, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Can not delete email destination that is not synced
4 participants