Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial and max width to main sections in detailed view #1155

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Jan 22, 2025

Closes #1149. Solution as shown at the flexbox-workshop with the team.

Wrap behaviour for children was already well defined.

@podliashanyk podliashanyk added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Jan 22, 2025
@podliashanyk podliashanyk requested a review from a team January 22, 2025 14:46
@podliashanyk podliashanyk self-assigned this Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Test results

   10 files  1 060 suites   38m 17s ⏱️
  536 tests   535 ✅  1 💤 0 ❌
5 360 runs  5 350 ✅ 10 💤 0 ❌

Results for commit 6c28727.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (605b38e) to head (6c28727).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1155   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files         141      141           
  Lines        5442     5442           
=======================================
  Hits         4271     4271           
  Misses       1171     1171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk force-pushed the stable-col-width-in-detailed-view branch from 64e4e4f to 6c28727 Compare January 22, 2025 15:32
Copy link
Contributor

@stveit stveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was gonna complain about the empty space to the right, but I see that is fixed by #1159

@podliashanyk podliashanyk merged commit 24d751c into master Jan 24, 2025
17 checks passed
@podliashanyk podliashanyk deleted the stable-col-width-in-detailed-view branch January 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize colon width for sections in detailed incident view
4 participants