-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace flake8 with ruff #869
Replace flake8 with ruff #869
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 84.29% 84.25% -0.05%
==========================================
Files 86 86
Lines 3973 3950 -23
==========================================
- Hits 3349 3328 -21
+ Misses 624 622 -2 ☔ View full report in Codecov by Sentry. |
b37b4c3
to
115d641
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you split this into several PR's?
One that:
- changes everything that must be able to run locally first ("ruff format" instead of black in pre-commit)
- then one that "ruff format"s all code
Then we'll need to directly push a revision to ignore blames for.
Then, we can replace flake8 with ruff for the "critical" stuff in pre-commit and tox and github actions in a new PR.
Finally, we can argue if we want to lint everything via pre-commit/tox/github actions and how many reviews that would take.
If we use ruff directly to lint, will we need Megalinter at all?
No, we won't. At least not when we have also switched to ruff for formatting. |
This PR will be split into multiple smaller PRs and needs to be strongly rebased |
Dependent on #868.