Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise RetryError if Zino1 is flaky on getattrs response #42

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Nov 29, 2023

Closes #35

Howitz will have to handle it somehow.

@hmpf hmpf self-assigned this Nov 29, 2023
Copy link

github-actions bot commented Nov 29, 2023

Test results

    3 files      3 suites   41s ⏱️
  63 tests   63 ✔️ 0 💤 0
189 runs  189 ✔️ 0 💤 0

Results for commit 8a9c05a.

♻️ This comment has been updated with latest results.

@hmpf hmpf force-pushed the mark-event-fetch-for-retry branch from 7f531be to 41038d1 Compare December 1, 2023 14:24
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (f066d26) 71.51% compared to head (8a9c05a) 71.78%.
Report is 10 commits behind head on main.

Files Patch % Lines
src/zinolib/controllers/zino1.py 58.69% 19 Missing ⚠️
src/zinolib/ritz.py 27.77% 13 Missing ⚠️
src/zinolib/config/zino1.py 57.89% 8 Missing ⚠️
src/zinolib/event_types.py 82.35% 3 Missing ⚠️
src/zinolib/utils.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   71.51%   71.78%   +0.26%     
==========================================
  Files          13       13              
  Lines        1271     1354      +83     
==========================================
+ Hits          909      972      +63     
- Misses        362      382      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmpf hmpf force-pushed the mark-event-fetch-for-retry branch from 41038d1 to 8a9c05a Compare December 1, 2023 14:50
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hmpf hmpf merged commit 9e45585 into Uninett:main Dec 5, 2023
8 of 9 checks passed
@hmpf hmpf deleted the mark-event-fetch-for-retry branch December 5, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: create_event_id gets unexpected output from get_attrlist()
2 participants