Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/settings restore value when dismissing keyboard #58

Merged

Conversation

tonelli-m
Copy link
Collaborator

Description

A few adjustments to the way keyboard behaves in settings screen, see below for details

Changes

  • When dismissing the keyboard, restore value back to the currently stored value. That means if an invalid value is entered, when keyboard will dismiss the last entered valid value will be restored in the field
  • Keyboard now dismisses when tapping outside of the field or when scrolling
  • Now that keyboard can be dismissed without back or done button press, we can use the decimal keyboard again for iOS (previously the regular keyboard was used because iOS decimal keyboard doesn't have a done button)
  • For values that should not be negative, use unsigned integers so that entering a negative value in the field triggers a validation error

Linked issues

#57

Remaining TODOs

N/A

Checklist

  • Code compiles correctly on all platforms
  • All pre-existing tests are passing
  • If needed, new tests have been added
  • Extended the README / documentation if necessary
  • Added code has been documented

@tonelli-m tonelli-m added KMP Shared Kotlin code Android Android related code iOS iOS related code labels Dec 5, 2024
@nicolas-f
Copy link
Member

Thanks for the PR

@nicolas-f nicolas-f merged commit c223dd9 into version/0.2.0 Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android related code iOS iOS related code KMP Shared Kotlin code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants