fix: when skipping a call due to throttle count one more skipped

[gastonfournier]

About the changes

When skipping http calls due to throttling we should also count that we skipped that call so the throttler can recover. This is done in the metrics implementation:

unleash-android/unleashandroidsdk/src/main/java/io/getunleash/android/metrics/MetricsSender.kt

Lines 77 to 79 in 5c52d66

	} else {
	throttler.skipped()
	}

but not in the feature toggle fetcher.

Closes #99

Discussion points

Maybe this can be refactored so the client of the throttler doesn't have to remember to call skipped. I have something like this in mind but it can be something good for a contribution, as I'm prioritizing fixing the bug.

        return throttler.execute {
            Log.d(TAG, "Refreshing toggles")
            val response = doFetchToggles(ctx)
            fetcherHeartbeatFlow.emit(HeartbeatEvent(response.status, response.error?.message))
            return@execute response
        }.orElseGet {
            Log.i(TAG, "Skipping refresh toggles due to throttling")
            fetcherHeartbeatFlow.emit(HeartbeatEvent(Status.THROTTLED))
            return ToggleResponse(Status.THROTTLED)
        }

[chriswk]

LGTM. might be worth it to put your thoughts about next step in an issue?

[gastonfournier]

LGTM. might be worth it to put your thoughts about next step in an issue?

Added #101