feat: react to network availability #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonfournier
commented
Jul 15, 2024
| @@ -1,4 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | |||
| <uses-permission android:name="android.permission.INTERNET" /> | |||
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> | |||
There was a problem hiding this comment.
I wonder if this is something we need to declare here or if we have to ask users to provide this permission (in other words, can we make this permission optional?)
There was a problem hiding this comment.
If I understand correctly, libraries should declare what they want/need as well. So we should have this here
| @@ -101,8 +103,10 @@ class DefaultUnleash( | |||
| ) | |||
| ) | |||
| } | |||
| }.toImmutableList() | |||
| }.toImmutableList(), | |||
| networkAvailable = networkStatusHelper.isAvailable() | |||
There was a problem hiding this comment.
Initial value
gastonfournier
force-pushed
the
react-to-network-changes
branch
from
67369e1 to
43da832
Compare
chriswk
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a listener to network changes. The implementation adapts to different API levels. If above 23 it uses the new mechanism and otherwise it falls back to the previous mechanism