chore: pull engine version from yggdrasil

Unleash · Jan 15, 2025 · cbaa590 · cbaa590
1 parent 937b29c
commit cbaa590
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -59,7 +59,7 @@
         <dependency>
             <groupId>io.getunleash</groupId>
             <artifactId>yggdrasil-engine</artifactId>
-            <version>0.1.0-alpha.12</version>
+            <version>0.1.0-alpha.13</version>
             <classifier>${os.detected.classifier}</classifier>
         </dependency>
         <dependency>

diff --git a/src/main/java/io/getunleash/metric/ClientMetrics.java b/src/main/java/io/getunleash/metric/ClientMetrics.java
@@ -1,6 +1,7 @@
 package io.getunleash.metric;
 
 import io.getunleash.engine.MetricsBucket;
+import io.getunleash.engine.UnleashEngine;
 import io.getunleash.event.UnleashEvent;
 import io.getunleash.event.UnleashSubscriber;
 import io.getunleash.lang.Nullable;
@@ -25,7 +26,7 @@ public class ClientMetrics implements UnleashEvent {
         this.specVersion = config.getClientSpecificationVersion();
         this.platformName = System.getProperty("java.vm.name");
         this.platformVersion = System.getProperty("java.version");
-        this.yggdrasilVersion = null;
+        this.yggdrasilVersion = UnleashEngine.getCoreVersion();
     }
 
     public String getAppName() {

diff --git a/src/main/java/io/getunleash/metric/ClientRegistration.java b/src/main/java/io/getunleash/metric/ClientRegistration.java
@@ -1,5 +1,6 @@
 package io.getunleash.metric;
 
+import io.getunleash.engine.UnleashEngine;
 import io.getunleash.event.UnleashEvent;
 import io.getunleash.event.UnleashSubscriber;
 import io.getunleash.lang.Nullable;
@@ -31,7 +32,7 @@ public class ClientRegistration implements UnleashEvent {
         this.specVersion = config.getClientSpecificationVersion();
         this.platformName = System.getProperty("java.vm.name");
         this.platformVersion = System.getProperty("java.version");
-        this.yggdrasilVersion = null;
+        this.yggdrasilVersion = UnleashEngine.getCoreVersion();
     }
 
     public String getAppName() {

diff --git a/src/test/java/io/getunleash/metric/UnleashMetricServiceImplTest.java b/src/test/java/io/getunleash/metric/UnleashMetricServiceImplTest.java
@@ -448,7 +448,7 @@ public void should_add_new_metrics_data_to_bucket() {
         verify(sender, times(1)).sendMetrics(metricsSent.capture());
         ClientMetrics metrics = metricsSent.getValue();
         assertThat(metrics.getSpecVersion()).isNotEmpty();
-        assertThat(metrics.getYggdrasilVersion()).isNull();
+        assertThat(metrics.getYggdrasilVersion()).isNotEmpty();
         assertThat(metrics.getPlatformName()).isNotEmpty();
         assertThat(metrics.getPlatformVersion()).isNotEmpty();
     }
@@ -467,6 +467,6 @@ public void client_registration_also_includes_new_metrics_metadata() {
         assertThat(reg.getPlatformName()).isNotEmpty();
         assertThat(reg.getPlatformVersion()).isNotEmpty();
         assertThat(reg.getSpecVersion()).isEqualTo(config.getClientSpecificationVersion());
-        assertThat(reg.getYggdrasilVersion()).isNull();
+        assertThat(reg.getYggdrasilVersion()).isNotEmpty();
     }
 }