feat: variant feature status - client specification update #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tymek
force-pushed
the
feat/variant-interface-with-feature-enabled
branch
from
2953c43 to
51e601b
Compare
nunogois
reviewed
Nov 9, 2023
| @@ -32,18 +32,14 @@ export interface Variant { | |||
| name: string; | |||
| enabled: boolean; | |||
| payload?: Payload; | |||
| feature_enabled?: boolean; | |||
There was a problem hiding this comment.
Do we need this one to be optional here? 🤔 Would it break anything if we made it required?
There was a problem hiding this comment.
We can make it required in next version. I'd like to avoid breaking "fallback variant" interface
nunogois
approved these changes
Nov 9, 2023
renovate bot
referenced
this pull request
in Unleash/unleash
Dec 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unleash-client](https://togithub.com/Unleash/unleash-client-node) | [`5.0.0` -> `5.3.0`](https://renovatebot.com/diffs/npm/unleash-client/5.0.0/5.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-node (unleash-client)</summary> ### [`v5.3.0`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v5.3.0) [Compare Source](https://togithub.com/Unleash/unleash-client-node/compare/v5.2.0...v5.3.0) #### What's Changed - fix: backward compatibility by [@​gastonfournier](https://togithub.com/gastonfournier) in [https://github.com/Unleash/unleash-client-node/pull/540](https://togithub.com/Unleash/unleash-client-node/pull/540) **Full Changelog**: Unleash/unleash-client-node@v5.2.0...v5.3.0 ### [`v5.2.0`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v5.2.0) [Compare Source](https://togithub.com/Unleash/unleash-client-node/compare/v5.1.0...v5.2.0) #### What's Changed - chore(deps): update dependency [@​types/semver](https://togithub.com/types/semver) to v7.5.5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/Unleash/unleash-client-node/pull/527](https://togithub.com/Unleash/unleash-client-node/pull/527) - feat: Backoff based on HTTP statuses by [@​chriswk](https://togithub.com/chriswk) in [https://github.com/Unleash/unleash-client-node/pull/537](https://togithub.com/Unleash/unleash-client-node/pull/537) **Full Changelog**: Unleash/unleash-client-node@v5.1.0...v5.2.0 ### [`v5.1.0`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v5.1.0) [Compare Source](https://togithub.com/Unleash/unleash-client-node/compare/v5.0.0...v5.1.0) #### What's Changed - feat: variant feature status - client specification update by [@​Tymek](https://togithub.com/Tymek) in [https://github.com/Unleash/unleash-client-node/pull/536](https://togithub.com/Unleash/unleash-client-node/pull/536) **Full Changelog**: Unleash/unleash-client-node@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adds a new "feature_enabled" property to the variant response, similar to Unleash/unleash-client-python#285
https://linear.app/unleash/issue/SR-152/node-sdk-add-feature-enabled-property-to-variant-response