Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for failed requests #412

Closed
lukasz-leszczuk-airspace-intelligence opened this issue Feb 1, 2024 · 1 comment · Fixed by #414
Closed

Add metrics for failed requests #412

lukasz-leszczuk-airspace-intelligence opened this issue Feb 1, 2024 · 1 comment · Fixed by #414
Labels
enhancement New feature or request

Comments

@lukasz-leszczuk-airspace-intelligence

Describe the feature request

I want to know what error status codes (4xx|5xx) were returned by edge, so that I can fine tune monitoring and runbooks.
Currently those are explicitly ommited (

// Ignore actix errors for metrics
), but I believe would still provide much value in speeding up debugging process.

Background

No response

Solution suggestions

Move metrics update before if let Ok(res) = res {} block

@nunogois
Copy link
Member

nunogois commented Feb 1, 2024

Hey @lukasz-leszczuk-airspace-intelligence, thanks for raising this issue! I'll reach out to the rest of the team and we'll get back to you.

@nunogois nunogois moved this from New to In Progress in Issues and PRs Feb 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants