feat: add metrics for failed requests #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
commented
Feb 1, 2024
| let registry = registry.unwrap_or_else(instantiate_registry); | ||
| register_custom_metrics(®istry); | ||
| instantiate_prometheus_metrics_handler(registry) | ||
| } |
There was a problem hiding this comment.
This was needed to avoid SetGlobalDefaultError("a global default trace dispatcher has already been set"), since the normal instantiate runs instantiate_tracing_and_logging(log_format);, which includes tracing::subscriber::set_global_default(collector).unwrap();.
sighphyre
approved these changes
Feb 2, 2024
sighphyre
reviewed
Feb 2, 2024
chriswk
reviewed
Feb 2, 2024
| let metrics_output = String::from_utf8(buffer).unwrap(); | ||
|
|
||
| let value_ok = parse_metrics_for_status_code(&metrics_output, 200).expect("Metric with status code 200 not found"); | ||
| assert_eq!(value_ok, -1.0, "Metric value for status code 200 did not match expected"); |
There was a problem hiding this comment.
and same thing for the other values. I see we reduce by -1.0 once it's done, I'm expecting the active_requests to fluctuate between 0 and however many simultaneous connections we can handle. so it being -1.0 would mean it only went through the it's done branch instead of both the started and it's done branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics for failed requests.
Closes #412