Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: obey http status responses. backoff when 429 or 50x #339

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Nov 16, 2023

Same thing here as in node and Java. In order to respect our upstream servers trying to tell us to chill out, this PR adds handling for 429, 500, 502, 503, 504. Edge already handled 401,403 and 404, so didn't need to change anything for that.

@chriswk chriswk requested a review from sighphyre November 16, 2023 09:31
@chriswk chriswk self-assigned this Nov 16, 2023
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good to me

@chriswk chriswk merged commit 33a511d into main Nov 23, 2023
4 checks passed
@chriswk chriswk deleted the task/obeyHttpStatusesFromUpstream branch November 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants