Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Upgrading Rustls to 0.22 and Actix to 4.5 #417

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Feb 6, 2024

Updated to Rustls 0.22 and actix 4.5. :)

@chriswk chriswk requested a review from sighphyre February 6, 2024 14:24
@chriswk chriswk force-pushed the task/upgradeActixAndRustls branch from a011862 to e9fd4fe Compare February 6, 2024 14:24
server/src/tls.rs Fixed Show resolved Hide resolved
@@ -756,7 +756,7 @@ mod tests {
),
|_| AppConfig::default(),
))
.rustls_021_with_config(server_config, tls_acceptor_config)
.rustls_0_22_with_config(server_config, tls_acceptor_config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really useful to this PR but I'm just fascinated that a function has a version string in the name

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, guessing the build error will disappear when we merge main after cargo dist update

@chriswk chriswk force-pushed the task/upgradeActixAndRustls branch from adc1a3f to 268a2f3 Compare February 28, 2024 12:48
@chriswk chriswk enabled auto-merge (squash) February 28, 2024 12:50
@chriswk chriswk merged commit daa9cdb into main Feb 28, 2024
9 checks passed
@chriswk chriswk deleted the task/upgradeActixAndRustls branch February 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants