Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent persistence from saving empty data sets #452

Merged
merged 2 commits into from
May 7, 2024

Conversation

sighphyre
Copy link
Member

This stops Edge from writing data to cache when the caches are empty. This prevents Edge instances that cannot communicate to upstream from poisoning the cache

Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sighphyre sighphyre merged commit 45552e7 into main May 7, 2024
9 checks passed
@sighphyre sighphyre deleted the fix/prevent-persister-from-saving-empty-data branch May 7, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants