Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade types library to add new metrics data and backwards compat for impression_data #489

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

sighphyre
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jul 19, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

Cargo.lock

PackageVersionLicenseIssue Type
unleash-yggdrasil0.13.0NullUnknown License

server/Cargo.toml

PackageVersionLicenseIssue Type
unleash-yggdrasil>= 0.13.0, < 0.14.0NullUnknown License
Denied Licenses: GPL-1.0, GPL-2.0, GPL-3.0, LGPL-2.1, LGPL-3.0, MPL-2.0, AGPL-3.0

OpenSSF Scorecard

PackageVersionScoreDetails
cargo/unleash-types 0.13.0 UnknownUnknown
cargo/unleash-yggdrasil 0.13.0 UnknownUnknown
cargo/unleash-types >= 0.13.0, < 0.14.0 UnknownUnknown
cargo/unleash-yggdrasil >= 0.13.0, < 0.14.0 UnknownUnknown

Scanned Manifest Files

Cargo.lock
server/Cargo.toml
  • unleash-types@>= 0.13.0, < 0.14.0
  • unleash-yggdrasil@>= 0.13.0, < 0.14.0
  • unleash-types@>= 0.12.0, < 0.13.0
  • unleash-yggdrasil@>= 0.12.0, < 0.13.0

…s new optional metrics data and adds backwards compatability for impression_data
@sighphyre sighphyre force-pushed the feat/upgrade-types branch from 2932b01 to c464824 Compare July 19, 2024 09:15
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should've implemented default for MetricsMetadata?

Not a blocker. Here's a 👍

@sighphyre sighphyre merged commit 9795c7c into main Jul 19, 2024
10 checks passed
@sighphyre sighphyre deleted the feat/upgrade-types branch July 19, 2024 09:28
@sighphyre
Copy link
Member Author

Maybe we should've implemented default for MetricsMetadata?

Not a blocker. Here's a 👍

I did think about it, I kinda want this to be a conscious choice. If it turns out its a pain we add it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants