Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verbose error for instance urls with api suffix #520

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Sep 6, 2024

About the changes

In context of Edge, instance URL is easy to mistake with SDK API URL. This could've save me couple minutes of confusion.

WARN schedule_revalidation_of_startup_tokens: unleash_edge::http::unleash_client: Failed to validate tokens. Requested url: [https://sandbox.getunleash.io/enterprise/api/edge/validate]. Got status: 401
INFO schedule_revalidation_of_startup_tokens: unleash_edge::http::unleash_client: Try passing the instance URL without '/api'.

Discussion points

  • Do we want it as part of the warning instead?
  • Do we expect tests for this change?

Copy link

github-actions bot commented Sep 6, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@chriswk
Copy link
Member

chriswk commented Sep 17, 2024

I think I'm fine with no tests here. I like the log message.

@chriswk chriswk enabled auto-merge (squash) September 17, 2024 12:29
@chriswk chriswk merged commit 10d3854 into main Sep 17, 2024
9 checks passed
@chriswk chriswk deleted the feat/better-url-error branch September 17, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants