-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump opentelemetry dependencies to 0.27 #596
Conversation
Dependency ReviewThe following issues were found:
License Issuesserver/Cargo.toml
Denied Licenses: GPL-1.0, GPL-2.0, GPL-3.0, LGPL-2.1, LGPL-3.0, AGPL-3.0 OpenSSF ScorecardScorecard details
Scanned Files
|
Some(opentelemetry_semantic_conventions::SCHEMA_URL), | ||
None, | ||
) | ||
meter_provider.meter("unleash_edge") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have open telemetry schema url and cargo pkg version here?
I found some docs indicating we can do:
meter_provider.meter_with_scope(InstrumentationScope::builder("unleash_edge")
.with_version(env!("CARGO_PKG_VERSION"))
.with_schema_url(opentelemetry_semantic_conventions::SCHEMA_URL)
.build())
but maybe this change is intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you found what I was looking for. Updated to use your suggestion. Thanks :)
global::handle_error(MetricsError::Other(err.to_string())); | ||
} | ||
|
||
let _ = encoder.encode(&metric_families[..], &mut buf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we missing here the global handle error call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because it wasn't being exposed anymore
b316cfb
to
e0db7c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, LGTM!
So. Finally opentelemetry prometheus updated to 0.27, so we can move on from 0.24.
This PR updates all opentelemetry dependencies to 0.27.