feat: start using instance_id argument for instance_id header #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
approved these changes
Dec 20, 2024
server/src/http/feature_refresher.rs
Outdated
Comment on lines
279
to
280
| app_name: String, | ||
| instance_id: String, | ||
| custom_headers: Vec<(String, String)>, |
There was a problem hiding this comment.
Ooh, this is a little sticky again. Having two very similar arguments with very similar values of the same type next to each other is a little dodgy. It'll be easy to flip them around. Can we chuck 'em in a config struct or use the type system to differentiate them?
There was a problem hiding this comment.
Changes this to also take the meta_information. Don't know why I hadn't already done that.
chriswk
force-pushed
the
614-edges-instance-ids-should-be-unique-and-configurable
branch
from
d3e7c34 to
4e84a41
Compare
chriswk
deleted the
614-edges-instance-ids-should-be-unique-and-configurable
branch
This was referenced Jan 8, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 15, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 21, 2025
Closed
Closed
Closed
Closed
This was referenced Jan 29, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #614