-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: start logging diff comparing with delta #666
Conversation
Dependency ReviewThe following issues were found:
License Issuesserver/Cargo.toml
Denied Licenses: GPL-1.0, GPL-2.0, GPL-3.0, LGPL-2.1, LGPL-3.0, AGPL-3.0 OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
@@ -470,7 +509,7 @@ impl FeatureRefresher { | |||
.unleash_client | |||
.get_client_features(ClientFeaturesRequest { | |||
api_key: refresh.token.token.clone(), | |||
etag: refresh.etag, | |||
etag: refresh.etag.clone(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did it suddenly need a clone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was due to
--> server/src/http/refresher/feature_refresher.rs:526:50
|
512 | etag: refresh.etag,
| ------------ value partially moved here
...
526 | self.compare_delta_cache(&refresh).await;
| ^^^^^^^^ value borrowed here after partial move
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, but I'm 👍 here. Good job
Co-authored-by: Christopher Kolstad <[email protected]>
Now when client/features is called, it will also call delta API and verify that payload matches.
This is behind feature flag.