-
-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: max parallel sessions config #9109
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
@@ -638,6 +642,12 @@ export function createConfig(options: IUnleashOptions): IUnleashConfig { | |||
ui.environment, | |||
isTest, | |||
); | |||
|
|||
const session: ISessionOption = mergeAll([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved so that isEnterprise is available
@@ -201,6 +201,7 @@ unleash.start(unleashOptions); | |||
instructing the browser to clear all cookies on the same domain Unleash is running on. If disabled unleash will | |||
only destroy and clear the session cookie. Defaults to _true_. `SESSION_CLEAR_SITE_DATA_ON_LOGOUT` | |||
- _cookieName_ - Name of the cookies used to hold the session id. Defaults to 'unleash-session'. | |||
- _maxParallelSessions_ - The maximum number of parallel user sessions with password based login. `MAX_PARALLEL_SESSIONS` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documenting the new option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looks good.
About the changes
Removing deleteStaleUserSessions flag and introducing MAX_PARALLEL_SESSIONS config with env var.
Defaults:
Self-hosted can override the env var.
What's the main use case for this env var? 1 parallel session enforcement for security purposes
Important files
Discussion points