-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ignore website docs generated in biome #9168
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
biome.json
Outdated
@@ -1,5 +1,8 @@ | |||
{ | |||
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json", | |||
"files": { | |||
"maxSize": 2097152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it safe to increase it for SEO/WebPerf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By adding the generated folder to the ignore lists we no longer need this, so I'm removing it. I don't expect this to impact SEO/WebPerf at all, it's just a sane limit that Biome has by default to not load large files. See: https://biomejs.dev/reference/configuration/#filesmaxsize
https://linear.app/unleash/issue/2-3208/add-website-docs-generated-folder-to-biome-ignore-lists
Noticed when running
yarn lint
locally that we get this error:To overcome this, this PR adds
website/docs/generated
to the ignore list of both the linter and formatter in our Biome settings.