Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send the add release plan change request from dialog when submitted #9174

Merged

Conversation

daveleek
Copy link
Contributor

Implements sending the change request of add release plan when submitted

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 7:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jan 30, 2025 7:36am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@daveleek daveleek requested review from kwasniew and nunogois January 30, 2025 09:49
feature: featureId,
action: 'addReleasePlan',
payload: {
templateId: releaseTemplate?.id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sticking with just the ID for now instead of the whole thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of right now this is what is implemented in the backend. I've not gotten to start looking into that decision yet :S

@daveleek daveleek merged commit b04079c into main Jan 30, 2025
13 checks passed
@daveleek daveleek deleted the feat/add-release-plan-change-request-dialog-send-request branch January 30, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants