Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karmveer/feature/27/auth pages #87

Merged
merged 20 commits into from
Jun 29, 2024
Merged

Conversation

Karmveer27
Copy link
Contributor

closes #27
closes #26
Finished frontend for sign up and login
Inprogress frontend for user-info
Mofied nav bar to change what it shows whether you are logged in or not

web/src/App.tsx Outdated
@@ -3,18 +3,15 @@ import Header from "./components/Header";
import Footer from "./components/Footer";

const App = () => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use main code for this page. The styling added is out of date

Copy link
Contributor

@gmat224 gmat224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix comment, then feel free to merge

Copy link
Contributor

@Harsheel12 Harsheel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Harsheel12 Harsheel12 merged commit a2aa55c into main Jun 29, 2024
4 checks passed
@gmat224 gmat224 deleted the Karmveer/feature/27/auth-pages branch June 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log-in page Sign-up page
3 participants