Wrote tests & endpoint for change password #106
Conversation
gaidukev
requested review from
dimassudjito,
the-rooster and
Sooraj-beep
as code owners
| const User = require("../models/user.model"); | ||
| const Authenticator = require("../services/Authenticator"); | ||
| const OnRegisterTokenVerifier = require("../services/OnRegisterTokenVerifier"); | ||
| const NewUserCreator = require("../services/NewUserCreator"); |
There was a problem hiding this comment.
We don't want to include code formatting changes in PR. If you are using a code formatting tool then add this file to its .ignore
| const token = req.body.token; | ||
| const username = req.body.username; | ||
| const role = req.body.role; | ||
| const token = req.body.token; |
There was a problem hiding this comment.
do not include whitespace changes
| return res.status(400).json({ message: "Invalid username or role" }); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
do not include formatting changes
|
|
||
| router.route("/auth/change_password").post(userController.change_password); |
There was a problem hiding this comment.
Only a user who is authenticated can change their password. This means they should have a valid jwt token and we should verify it before changing password. Check this file to see what this function would look like: https://github.com/UofA-Blueprint/AlzheimerCalgary/blob/develop/server/services/OnRegisterTokenVerifier.js
You would want to make a general case function similar to the above. Then call this verifier function before calling changePassword
| ////////////////////////// |
There was a problem hiding this comment.
get rid of whitespace changes
No description provided.