added a change function color parameter for issue #151 #153

AlexandreArduino · 2022-02-08T11:56:06Z

You can now change the function color as asked in the issue

nw_function_color.mp4

github-actions · 2022-02-08T12:02:45Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	810776 bytes	442100 bytes	226888 bytes	1776 bytes	228664 bytes	1254652 bytes
Head	811680 bytes	442916 bytes	226888 bytes	1776 bytes	228664 bytes	1256372 bytes
	+904 bytes	+816 bytes	+0 bytes	+0 bytes	+0 bytes	+1720 bytes
	+0.1 %	+0.2 %	+0.0 %	+0.0 %	+0.0 %	+0.1 %

Yaya-Cout · 2022-02-08T12:26:05Z

I think something like this (numworks#1385) or this (numworks#1741) will be more readable, and you wrote “vertt” instead of “vert”, but thanks you for this pull request

AlexandreArduino · 2022-02-08T13:34:46Z

it is aleady corrected for the "vertt" :p and for numworks#1741 i agree with you, i'll try to modify it later

RedGl0w · 2022-02-08T13:47:23Z

it is aleady corrected for the "vertt" :p and for numworks#1741 i agree with you, i'll try to modify it later

Sorry :p

Btw, I think that a more "compact" solution like the one used in numworks#1385 (comment) should be rather used that a list view.

AlexandreArduino · 2022-02-08T13:50:45Z

Yes sure but if we want to have the same ui in the whole calculator (numworks#1385 (comment) as said artaxxx) it's better to use a list view but you're right that it's not very compact :p

Lauryy06 · 2022-02-08T17:21:51Z

I think the implementation that Redglow showed is indeed better.

AlexandreArduino · 2022-02-08T19:07:38Z

okay no problem :p

RedGl0w · 2022-02-08T19:11:25Z

I think the implementation that Redglow showed is indeed better.

However, I'm not personally convinced in the square selector (the idea is very good, but it can be a bit not User friendly)
I don't know what would be better, but I still prefer this one to the list menu

Lauryy06 · 2022-02-11T12:36:15Z

apps/graph/list/color_list.cpp

+            if(color == KDColorBlack) return Message(0);
+            if(color == KDColorBlue) return Message(1);
+            if(color == KDColorRed) return Message(2);
+            if(color == KDColorPurple) return Message(3);
+            if(color == KDColorGreen) return Message(4);
+            if(color == KDColorOrange) return Message(5);
+            if(color == KDColorYellow) return Message(6);
+            if(color == KDColorWhite) return Message(7);
+            return Message(2);


You can use a switch here

yes I had this idea but sometimes in the code you use many if(...) instead of a switch so I thought it was what I had to do but 🤔 but i correct it

finally I tried the switch but I've got an error : error: call to non-‘constexpr’ function ‘KDColor::operator uint16_t() const’
case KDColorWhite: return Message(7);
So for now, I remove it :p

apps/graph/list/color_list.cpp

github-actions · 2022-02-14T08:41:16Z

	.text	.rodata	.bss	.data	Total (RAM)	Total (ROM)
Base	810776 bytes	442100 bytes	226888 bytes	1776 bytes	228664 bytes	1254652 bytes
Head	811680 bytes	442916 bytes	226888 bytes	1776 bytes	228664 bytes	1256372 bytes
	+904 bytes	+816 bytes	+0 bytes	+0 bytes	+0 bytes	+1720 bytes
	+0.1 %	+0.2 %	+0.0 %	+0.0 %	+0.0 %	+0.1 %

Lauryy06 · 2022-02-14T20:32:44Z

apps/graph/base.de.i18n

@@ -31,3 +31,11 @@ DerivativeFunctionColumn = "Spalte der Ableitungsfunktion"
 HideDerivativeColumn = "Ableitungsfunktion ausblenden"
 AllowedCharactersAZaz09 = "Erlaubt: A..Z, a..z, 0..9, _"
 ReservedName = "Reserviertes Wort"
+FunctionColorBlack = "schwarz"


Is it possible to start the colors with a capital letter?

I don't know how to do that 🤣 no i'm joking but you think this pr is still valid ? bc it is not very compact 🤔 as said @RedGl0w

I don't know how to do that

Just change the text...

Suggested change

FunctionColorBlack = "schwarz"

FunctionColorBlack = "Schwarz"

(and add a line at the end of each file please)

For the name of the colors, instead of somehow duplicating them, couldn't you rather use the pythonColors ?

I think it is better to move the Python colour names in the shared i18n file in this case to can build without the Python app.

RedGl0w

Some epsilon coding style fixes

RedGl0w · 2022-02-16T07:53:08Z

apps/graph/base.de.i18n

+FunctionColorGreen = "grün"
+FunctionColorOrange = "Orange"
+FunctionColorYellow = "gelb"
+FunctionColorWhite = "weiß"


Add carriage return (for all files which don't have it)

okay i do that

RedGl0w · 2022-02-16T07:53:38Z

apps/graph/list/color_list.cpp

+#include "color_list.h"
+#include "apps/i18n.h"
+
+namespace Graph {


Don't indent after namespace (for all files)

RedGl0w · 2022-02-16T07:54:04Z

apps/graph/list/color_list.cpp

+
+namespace Graph {
+    I18n::Message Message(int index) {
+        static constexpr I18n::Message message[NumberOfColors] = {


Indentation should be made of 2 spaces (for all files)

RedGl0w · 2022-02-16T07:56:11Z

apps/graph/list/color_list.h

@@ -0,0 +1,12 @@
+#pragma once


Suggested change

#pragma once

#ifndef GRAPH_COLOR_LIST_H

#define GRAPH_COLOR_LIST_H

This should be done in all header

Yaya-Cout · 2022-02-27T11:06:45Z

Can you add a space before the function colour arrow ? (it is ugly without space)

Can you also show the colour in the submenu, like numworks#1741 ? (the white colour isn't visible when it isn't selected)

added a change function color parameter

86a3f45

AlexandreArduino mentioned this pull request Feb 8, 2022

Redefinir les couleurs des courbes #151

Closed

Lauryy06 reviewed Feb 11, 2022

View reviewed changes

apps/graph/list/color_list.cpp Outdated Show resolved Hide resolved

removed unused namespace

6c89889

Lauryy06 reviewed Feb 14, 2022

View reviewed changes

RedGl0w reviewed Feb 16, 2022

View reviewed changes

Yaya-Cout linked an issue Mar 2, 2022 that may be closed by this pull request

Redefinir les couleurs des courbes #151

Closed

Yaya-Cout mentioned this pull request Mar 22, 2022

[apps/graph] Added a color menu in graph and list #189

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added a change function color parameter for issue #151 #153

added a change function color parameter for issue #151 #153

AlexandreArduino commented Feb 8, 2022

github-actions bot commented Feb 8, 2022

Yaya-Cout commented Feb 8, 2022

AlexandreArduino commented Feb 8, 2022

RedGl0w commented Feb 8, 2022

AlexandreArduino commented Feb 8, 2022

Lauryy06 commented Feb 8, 2022

AlexandreArduino commented Feb 8, 2022

RedGl0w commented Feb 8, 2022

Lauryy06 Feb 11, 2022

AlexandreArduino Feb 14, 2022

AlexandreArduino Feb 14, 2022

github-actions bot commented Feb 14, 2022

Lauryy06 Feb 14, 2022

AlexandreArduino Feb 15, 2022

Lauryy06 Feb 15, 2022 •

edited

Loading

RedGl0w Feb 16, 2022

Yaya-Cout Feb 27, 2022

RedGl0w left a comment

RedGl0w Feb 16, 2022

AlexandreArduino Feb 19, 2022

RedGl0w Feb 16, 2022

RedGl0w Feb 16, 2022

RedGl0w Feb 16, 2022

Yaya-Cout commented Feb 27, 2022

	FunctionColorBlack = "schwarz"
	FunctionColorBlack = "Schwarz"

	#pragma once
	#ifndef GRAPH_COLOR_LIST_H
	#define GRAPH_COLOR_LIST_H

added a change function color parameter for issue #151 #153

added a change function color parameter for issue #151 #153

Conversation

AlexandreArduino commented Feb 8, 2022

github-actions bot commented Feb 8, 2022

Yaya-Cout commented Feb 8, 2022

AlexandreArduino commented Feb 8, 2022

RedGl0w commented Feb 8, 2022

AlexandreArduino commented Feb 8, 2022

Lauryy06 commented Feb 8, 2022

AlexandreArduino commented Feb 8, 2022

RedGl0w commented Feb 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lauryy06 Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedGl0w left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yaya-Cout commented Feb 27, 2022

Lauryy06 Feb 15, 2022 •

edited

Loading